Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow account changes in cloudml_predict() and cloudml_train() #98

Closed
wants to merge 1 commit into from

Conversation

javierluraschi
Copy link
Contributor

See #94 - Looks like we can easily switch accounts to support the gcloud parameter.

@jjallaire
Copy link
Member

Could we make this a with_account() function which switches back to the previous account after the function completes?

@jjallaire
Copy link
Member

Besides saving and restoring this info, we also need to make sure we save and restore all of the gcloud config variables in play (account, project, and region). We also need to make sure that if the user provides a named configuration we read all of the values from the named configuration and set those during the job)

@jjallaire jjallaire closed this Jan 4, 2018
@jjallaire jjallaire reopened this Jan 4, 2018
@jjallaire
Copy link
Member

We also need to make sure that the gcloud parameter is available in the gs_ family of functions

@javierluraschi
Copy link
Contributor Author

Alright, let's close this one and I'll remove glcoud and replace with region for cloudml_train.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants