Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible http requests #101

Merged
merged 25 commits into from
May 14, 2021
Merged

Flexible http requests #101

merged 25 commits into from
May 14, 2021

Conversation

colearendt
Copy link
Member

Trying to make extending the HTTP client easier... (i.e. for special cookies, headers, etc.)

@colearendt colearendt added this to Doing in First CRAN Release Mar 26, 2021
@colearendt
Copy link
Member Author

We need to trace httr_additions through the PUT, HEAD, POST endpoints

colearendt and others added 20 commits May 12, 2021 15:25
@colearendt
Merge branch 'main' into flexible-http-requests
5e2ed42
@colearendt
Merge branch 'main' into flexible-http-requests
a9a7c69
@colearendt
add a vignette
b1066b2
@colearendt
Merge remote-tracking branch 'alt/main' into flexible-http-requests
9d77f94
@colearendt
tweak wording
5145d64 
fix TODO
@colearendt
Merge branch 'flexible-http-requests' of github.com:rstudio/connectap…
e3a12ce 
…i into flexible-http-requests
@colearendt
finish injecting customization for http requests
45390ae
@colearendt
rename add_httr to httr_config
0ed41e9
@colearendt
update article
27088be
@colearendt
allow turning off authorization header
908568d
@colearendt
add kerberos and proxy example
be25d4a
@colearendt
add a tryCatch around messaging content
1b0200a 
in some cases httr::content will not work
(i.e. if an HTML response and xml2 is not installed)
@colearendt
add a tryCatch to protect checks for Connect
3d31941 
this enables turning off in certain situations,
like when using Kerberos or a proxy and those initial requests
do not have the proper headers / cookies / etc.
@colearendt
fix check_is_fatal implementation
29fc716
@colearendt
add integration testing
bd1ddd2
@colearendt
update .check_is_fatal docs
7b6e521
@colearendt
Increment version number
09ac95b
@colearendt
add news entry
f0fc83d
@colearendt
update docs
c0842b6
@colearendt
handle curl errors better
6a65f2e
@colearendt
Copy link
Member Author

This is a little scary, since we're changing stuff that is very low level in the package (GET, POST requests, etc.). In any case, it seems stable! Here goes nothing!

@colearendt colearendt merged commit ea28ff9 into main May 14, 2021
@colearendt colearendt deleted the flexible-http-requests branch May 14, 2021 20:59
First CRAN Release automation moved this from Doing to Done May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
First CRAN Release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@colearendt