Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message from compareVersion #63

Closed
paddytobias opened this issue Dec 15, 2021 · 1 comment · Fixed by #64
Closed

Misleading error message from compareVersion #63

paddytobias opened this issue Dec 15, 2021 · 1 comment · Fixed by #64

Comments

@paddytobias
Copy link

Hi,

We were running into an issue on our landing pages that was telling us that our RSC server wasn't up to date, despite us running the latest version (2021.12)

image

After somedebugging, we realised the issue was that the version number was being hidden by the server as per here: https://docs.rstudio.com/connect/admin/appendix/configuration/#Server.HideVersion

Wondering, does the version number comparison need to be a hard check, i.e., error if the comparison fails ? Should it still run if the version is hidden?

If it should fail, then can we update the error message if there is no version number coming through

if (compareVersion(settings$version, self$minimum_server_version) < 0) {
stop(
glue::glue("ERROR: Requires RStudio Connect server version >= ",
self$minimum_server_version,
", current version ",
settings$version)
)
}
},

aronatkins added a commit that referenced this issue Dec 21, 2021
additionally, test-connect.R is no longer sensitive to incoming environment
variables.

fixes #63
@Lytol Lytol closed this as completed in #64 Jan 3, 2022
@aronatkins
Copy link
Contributor

@paddytobias, would you mind trying the latest version of the package? The lack of a server version is no longer an error.

You'll need to install from GitHub:

remotes::install_github("rstudio/connectwidgets")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants