-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL code blocks disappear #17
Comments
SourceDetailsThe
Results for R<pre>
<code id="code-container" class="language-clike">
data <span class="token operator"><</span>
<span class="token operator">-</span> iris
</code>
</pre> Results for Sql<code id="code-container"></code> |
Fixed via rstudio/radix@868669f Our only option here was to map languages not supported directly by Prism to "clike" |
I'm a little confused, apologies if I'm misunderstanding something at some point. :-) Prism.js supports 152 languages, including R and SQL: https://prismjs.com/#languages-list However, looking at the source of template/src/components/d-code.js from distill, they only explicitly import python, clike, lua, bash, go, markdown and julia. So this could be fixed "properly" by importing more languages - but is this something that radix could override, or would it need a pull request to distill? |
We'd have to remove the embedded Prism from Distill then replace it with another implementation. So far we've taken the approach not to fork/edit Distill but it may be that we'll ultimately need to. |
Going to close this and create a new issue covering adding more Prism languages. |
If I put a code block with SQL:
the contents disappear from the output. (A code block is there, but there's nothing in it.)
It doesn't appear to be SQL specific. There appears to be a list of languages that work (including r, c, cpp, java, python, julia, javascript, css) but anything else (sql, rust, haskell, d, brainfuck, ...) disappears.
The text was updated successfully, but these errors were encountered: