Add aria-label and aria-hidden to sharing icons
#426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
requested changes
Nov 24, 2021
There was a problem hiding this comment.
Looks good.
We should probably add aria-hidden on the icon no ?
Like other reference shared in #424 (comment)
Is this not required in your WAVE test report ?
|
Oh, duh! Makes sense—not sure why WAVE didn't complain about it, but I'll make the change. |
cderv
reviewed
Nov 24, 2021
cderv
reviewed
Nov 24, 2021
Co-authored-by: Christophe Dervieux <christophe.dervieux@gmail.com>
Co-authored-by: Christophe Dervieux <christophe.dervieux@gmail.com>
cderv
approved these changes
Nov 24, 2021
[skip ci]
cderv
changed the title
aria-label to sharing iconsaria-label and aria-hidden to sharing icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-labelto links that use FA icons for accessibility #424