Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navbar-right flex css #316

Closed
meztez opened this issue Mar 15, 2021 · 2 comments · Fixed by rstudio/bslib#286
Closed

navbar-right flex css #316

meztez opened this issue Mar 15, 2021 · 2 comments · Fixed by rstudio/bslib#286

Comments

@meztez
Copy link

meztez commented Mar 15, 2021

Using the latest bslib with flexdashboard, I believe the bootstrap css flex property for navbar messes with the navbar layout as it forces all flex elements to have the same width.

Reprex:

---
title: "Break Line"
author: "meztez"
output: 
  flexdashboard::flex_dashboard:
    orientation: rows
    vertical_layout: fill
    theme:
      version: 4
      bootswatch: cosmo
      primary: "#003366"
runtime: shiny_prerendered
---

Mercury
=====================================  

Venus
=====================================  

Earth
=====================================  

Mars
=====================================  

Jupiter
=====================================  

Uranus
=====================================  

Neptune
=====================================  

Pluto
=====================================

image

image

Switching theme to cosmo still works fine

theme: cosmo
cpsievert added a commit to rstudio/bslib that referenced this issue Mar 17, 2021
@cpsievert
Close rstudio/flexdashboard#316: unset flex property on navbar-right …
42e815e 
…container
@cpsievert cpsievert mentioned this issue Mar 17, 2021
Merged
@cpsievert
Copy link
Collaborator

Thanks @meztez. Try installing rstudio/bslib#286 for a tentative fix.

@meztez
Copy link
Author

meztez commented Mar 17, 2021 •
edited
Loading

@cpsievert Tested it, looks fine.

cpsievert added a commit to rstudio/bslib that referenced this issue Mar 17, 2021
@cpsievert
Unset flex property on navbar-right container (#286)
df10a87 
* Close rstudio/flexdashboard#316: unset flex property on navbar-right container

* Resave data (GitHub Action)

* Just undo the flex: 1 as it doesn't seem needed in the first place

* Set margin-left:auto since this is the BS4 recommendation

* Resave data (GitHub Action)

* Update news

Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unset flex property on navbar-right container rstudio/bslib
2 participants
@cpsievert @meztez