Add support for Okta as auth provider #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus improving relationship between session storage and secrets
statik
approved these changes
Nov 22, 2023
jspiewak
reviewed
Nov 27, 2023
| app.register_blueprint(oauth_blueprint, url_prefix="/login") | ||
|
|
||
| else: | ||
| warnings.warn(f"unknown auth provider {AUTH_PROVIDER!r}") |
There was a problem hiding this comment.
Probably should be an error. What state will FB be in if it has an unknown provider? Will calls fail?
There was a problem hiding this comment.
Or critical/fatal if that is a level.
jspiewak
reviewed
Nov 27, 2023
| OAUTH_MAX_AGE = parse_timedelta( | ||
| typing.cast( | ||
| str, | ||
| cfg.get("FUZZBUCKET_OAUTH_MAX_AGE", default="1 day"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
This set of changes is a bit more damp than I'd like given the mutual exclusivity of GitHub and Okta (generic OAuth2) providers and subtle differences between them. Maybe more drying later?