check_result api change #11 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chendaniely
force-pushed
the
check_result_api-#11
branch
from
0338924
to
550285c
Compare
chendaniely
force-pushed
the
check_result_api-#11
branch
from
c28081d
to
2c8bcc9
Compare
|
@schloerke I have a question of getting The following test will fail expect_error(
check_result(
fail_if(~ .result == 5, "You were supposed to do this other thing!"),
grader_args = list(solution_quo = quote(5)),
learnr_args = list(envir_prep = new.env())
)
)because I need one correct result to be passed (from if (!any(vapply(results, `[[`, logical(1), "correct"))) {
stop("At least one correct result must be provided")
}The problem is, that the match exists. So should I be taking out that Full code is in the |
schloerke
reviewed
Jul 1, 2019
schloerke
reviewed
Jul 1, 2019
schloerke
reviewed
Jul 1, 2019
schloerke
reviewed
Jul 1, 2019
schloerke
reviewed
Jul 4, 2019
chendaniely
commented
Jul 4, 2019
Closed
|
@schloerke, If this review is good, can we merge this and work on #29 separately? |
schloerke
reviewed
Jul 8, 2019
schloerke
reviewed
Jul 8, 2019
schloerke
requested changes
Jul 8, 2019
schloerke
previously approved these changes
Jul 9, 2019
chendaniely
commented
Jul 9, 2019
garrettgman
approved these changes
Jul 9, 2019
|
This PR also Fixes #29 |
chendaniely
changed the title
schloerke
pushed a commit
that referenced
this pull request
Jul 9, 2019
* add notes from meeting with baret * pass_if formula (need to fix API) * pass fail condi * some tests for condi formula objects * comment out sample code and add some comments * tests for fomula condition * remove old pass_fail_if code and tests * lintr * implement check_result pass_if with tests * get fail_if test working * check_result api for function and value * break check_results result function api * re-order function definitions (cosmetic) * update evaluate_condi to return graded obj or NULL * tests for evaluate_condi to expect graded obj instead of T/F * implement check_result api changes * remove extra line on top * add ending newline * documentation updates and condi -> condition) * fix lintr whitespace * roxygen doc changes after whitespace lint * expect_error -> expect_wrong (namespace testthat::expect_error) * pass in learnr_args not grader_args * move graded to separate r script * return the final_result$message, not message. the pass_if test in `test_grade_learnr.R` was not passing along the message from the `pass_if(message)` argument, but rather, it was passing along one of the random .praise values * Rd change after graded was moved to own file * barret review changes * fix test grade learnr to pass * remove last_value = quote() from test_check_result_condi * fixes #29 test grade_learnr bug return graded obj after resu match * evaluate_condi -> evaluate_condition * allow for condi message to be used in full message * add back break statement * correct the message in a unit test
chendaniely
added a commit
that referenced
this pull request
Aug 9, 2019
* comment out unused functions, move fxns to separate R files * remove learnr dependency (broken) * move and edit view/add/remove tutorial fxns waiting for feature to be implement in rstudio before putting back in also removes learnr depedency * remove dependencies (clean up scripts and files) removes call to pryr in grade_learnr and replace with rlang equlivilant move unused functions to archive. these are flagged for deletion. move old tutorial files to archive, will be added in when api is finalized, and still deemed necessary. * lintr! * remove test and result function from archive. result was removed in #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this PR gets merged it Fixes #11.
@schloerke @garrettgman I believe I have all the working parts in there, but I can't seem to get the actual
pass_ifAPI working the way it was described in #11.In the
pass_iffunction signature, should theuser_answer, grader_args = list(), learnr_args = list()all be passed as...?