Ignore differences between `ggplot2` arguments like `color` vs. `colour` in `code_feedback()` #353

rossellhayes · 2023-05-17T05:41:07Z

call_standardise_formals() now applies ggplot2::standardise_aes_names() to all arguments of ggplot2 functions. This means it no longer detects inconsequential differences between e.g. color = vs colour =

library(gradethis)
library(ggplot2)

code_feedback(
  "ggplot(mpg, aes(displ, hwy, color = class)) + geom_point()",
  "ggplot(mpg, aes(displ, hwy, colour = class)) + geom_point()"
)
#> NULL

^{Created on 2023-05-16 with reprex v2.0.2}

Closes #342.

…ults` arguments into recursive calls

…are lists Previously, this would also be applied to `pairlists`, which could mess up the standardization of function definitions, because a function's formal arguments are stored as a pairlist

…tandardize arguments to all calls, not just top-level calls

…nctions (e.g. convert `color =` to `colour =`)

…tches

…would lead to a name collision

#Conflicts: # R/call_standarise_formals.R # R/detect_mistakes.R # tests/testthat/test-call_standarise_formals.R

…fix functions

nischalshrestha

Nice!

rossellhayes added 5 commits May 16, 2023 22:30

fix(call_standardise_formals_recursive): pass env and `include_defa…

d6bd955

…ults` arguments into recursive calls

fix(call_standardise_formals_recursive): only apply list logic to b…

ae22b12

…are lists Previously, this would also be applied to `pairlists`, which could mess up the standardization of function definitions, because a function's formal arguments are stored as a pairlist

fix(detect_mistakes): use call_standardise_formals_recursive() to s…

a02685d

…tandardize arguments to all calls, not just top-level calls

feat(call_standardise_formals): standardize arguments to ggplot2 fu…

06867b9

…nctions (e.g. convert `color =` to `colour =`)

test(call_standardise_formals): test ggplot2 argument standardization

95f3bd0

rossellhayes self-assigned this May 17, 2023

rossellhayes requested a review from nischalshrestha May 17, 2023 05:41

rossellhayes added 8 commits May 17, 2023 09:45

fix(call_standardise_keep_partials): suppress warnings for partial ma…

4e6259e

…tches

fix(call_standardise_ggplot_arguments): don't change arguments if it …

eba0ebb

…would lead to a name collision

Merge commit '6c6eac7b1dd54dbe346f192c5c4e47731d7a2ae4'

825a82a

#Conflicts: # R/call_standarise_formals.R # R/detect_mistakes.R # tests/testthat/test-call_standarise_formals.R

fix: fix typo in file name of call_standardise_formals.R

1a0ac26

docs: update NEWS

cf38266

fix(call_standardise_formals): no need to standardise arguments to in…

0e1571e

…fix functions

fix(is_infix): add :: and ::: as infixes

f9f72b6

fix(is_infix): use identical() rather than %in% to identify infixes

1c55344

nischalshrestha approved these changes May 17, 2023

View reviewed changes

rossellhayes merged commit 7c0a4e4 into main May 17, 2023
11 checks passed

rossellhayes deleted the feat/standardize-color-colour branch May 17, 2023 20:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore differences between `ggplot2` arguments like `color` vs. `colour` in `code_feedback()` #353

Ignore differences between `ggplot2` arguments like `color` vs. `colour` in `code_feedback()` #353

rossellhayes commented May 17, 2023 •

edited

Loading

nischalshrestha left a comment

Ignore differences between ggplot2 arguments like color vs. colour in code_feedback() #353

Ignore differences between ggplot2 arguments like color vs. colour in code_feedback() #353

Conversation

rossellhayes commented May 17, 2023 • edited Loading

nischalshrestha left a comment

Choose a reason for hiding this comment

Ignore differences between `ggplot2` arguments like `color` vs. `colour` in `code_feedback()` #353

Ignore differences between `ggplot2` arguments like `color` vs. `colour` in `code_feedback()` #353

rossellhayes commented May 17, 2023 •

edited

Loading