Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grand_summary_rows does not produce latex output #303

Closed
steveputman opened this issue Jun 12, 2019 · 3 comments
Closed

grand_summary_rows does not produce latex output #303

steveputman opened this issue Jun 12, 2019 · 3 comments

Comments

@steveputman
Copy link
Contributor

I cannot get grand_summary_rows() to generate any latex output.

library(tidyverse)
#> Registered S3 methods overwritten by 'ggplot2':
#>   method         from 
#>   [.quosures     rlang
#>   c.quosures     rlang
#>   print.quosures rlang
library(gt)
library(knitr)

tribble(
  ~groupname, ~Subtype, ~Units,
  "Group1", "A", 100,
  "Group2", "B", 200) %>%
  gt() %>%
  grand_summary_rows(
    columns = vars(Units),
    fns = list(Total = ~sum(.))
  )

Created on 2019-06-12 by the reprex package (v0.3.0)

The HTML outputs fine; the latex is missing the summary row. I got the same result when using summary_rows() with groups = NULL, but groups = TRUE properly creates subtotals by group.

image

I do not know if this is related to the issue I referred to in #145 (comment), which relates to the missing midrule after the stub in a single-member final group, but that issue remains as well.

Thanks!

Steve

@rich-iannone
Copy link
Member

rich-iannone commented Jul 27, 2019

@steveputman thanks for filing this issue. It’s true that is hasn’t been implemented for anything other than HTML output. Actually there is not much parity with newly implemented features across the formats. The reason for this is that we are trying to finish up work on the HTML side (still wildly in flux, with lots of refactoring in the core pipeline) before shifting over to the other formats.

I know that you have some PRs and I’d like to take a moment to assure you that they are not being ignored. We are just being a little methodical in how we are approaching the work. Once we do move to working on LaTeX output, we are going to ensure there is full parity with HTML and everything ‘just works’!

@steveputman
Copy link
Contributor Author

@rich-iannone thanks for the info on the LaTeX, and no worries on the PRs: I'm just trying to keep up with any refactoring. I think we're down to just one dealing with the accounting-style formatting in the formatters that got refactored in your last release. Thanks again for all the amazing work on this.

@rich-iannone
Copy link
Member

This is now fixed with #768. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants