LaTeX bugfix for summary rows, and, implementation of grand summary rows #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
May 21, 2021
jcheng5
reviewed
May 21, 2021
jcheng5
reviewed
May 21, 2021
jcheng5
reviewed
May 21, 2021
* master: Reinstate once failing test Include stub var in resolution of visible vars Use `seq_len()` instead of `seq()` Fix typo in README (#765)
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 26, 2021
jcheng5
reviewed
May 28, 2021
jcheng5
approved these changes
May 28, 2021
rich-iannone
added a commit
that referenced
this pull request
May 28, 2021
* master: LaTeX bugfix for summary rows, and, implementation of grand summary rows (#768)
This was referenced Jun 2, 2021
Closed
rich-iannone
added a commit
that referenced
this pull request
Jun 11, 2021
* master: (24 commits) Fix for possible column name duplication when generating summary rows (#792) Change the `data` arg to `.data` to avoid partial matching issues (#772) Add the `force_sign` arg to several numeric formatters (#793) Add the `fmt_engineering()` and `fmt_integer()` formatter functions (#758) HTML summary row styling fix (#782) Refactor and improve rendering of title/subtitle components in HTML/LaTeX tables (#779) LaTeX bugfix for summary rows, and, implementation of grand summary rows (#768) Reinstate once failing test Include stub var in resolution of visible vars Use `seq_len()` instead of `seq()` Fix typo in README (#765) Increment version number (#762) Increase version number Documentation fixes (#759) Add missing topics to _pkgdown.yml Add `accounting` options for `fmt_percent()` and `fmt_number()` (#756) Simplify arguments for RTF page numbering Add the `fmt_bytes()` formatter function (#750) Simplify page numbering text Add testthat snapshot tests for RTF page numbering ...
This was referenced Jun 12, 2021
This was referenced Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the proper rendering of summary rows in LaTeX table outputs. On top of that, there's an implementation of grand summary rows for the first time (previously, grand summary rows would not be rendered).
Two .Rmds have also been added to the
scriptsfolder to aid in LaTeX testing (they serve as templates).Fixes: #625