-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the fmt_partsper()
function
#914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Make changes based on code review Correct stopifnot stmts Make changes based on code review Make corrections based on code review Don't show ind suffix for is.infinite(x) or x == 0 Simplify formatting in Ind number system Revise docs for `insert_seps_ind()` util fn Refactor insertion point calculation Add missing space Update test-fmt_percent.R Update test-fmt_fraction.R Update utils_formatters.R Update format_data.R Add several testthat tests Update help files using roxygen Ensure that 'ind' system produces suffixes Simplify formatting of integers Implement Indian numbering system support
jcheng5
suggested changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename
fmt_ratio
tofmt_partsper
- Take out the changes to
context_symbol_str
, leave that to (eventually) be currency-only
rich-iannone
changed the title
Add the
Add the Apr 8, 2022
fmt_ratio()
functionfmt_partsper()
function
* master: Improve layout of examples in documentation (#933)
jcheng5
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new
fmt_partsper()
function, we can now format values as high-ratio, dimensionless quantities. These are less common that percentage values but no less important (some of these are used extensively, depending on the field of study). The list of formats (with their associated keywords) are:"per-mille"
: Per mille, (1 part in1,000
)"per-myriad"
: Per myriad, (1 part in10,000
)"pcm"
: Per cent mille (1 part in100,000
)"ppm"
: Parts per million, (1 part in1,000,000
)"ppb"
: Parts per billion, (1 part in1,000,000,000
)"ppt"
: Parts per trillion, (1 part in1,000,000,000,000
)"ppq"
: Parts per quadrillion, (1 part in1,000,000,000,000,000
)The function is structured similarly to
fmt_percent()
but there is some flexibility here to provide a replacement symbol if needed (e.g.,ppm
->ppmV
).Here is an example with per mille formatting:
Fixes: #608