-
Notifications
You must be signed in to change notification settings - Fork 218
Settable font options #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Ensure that row ordering doesn't affect summary row calculations (#556)
jcheng5
reviewed
May 27, 2020
jcheng5
reviewed
May 27, 2020
jcheng5
reviewed
May 27, 2020
schloerke
reviewed
May 29, 2020
Member
|
Add unexported function for appending to |
Member
|
Notes from in-person discussion.
|
jcheng5
previously approved these changes
Jul 13, 2020
jcheng5
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify additional table fonts before the default set in the font family. This is done globally with the
opt_font()function, which either accepts a local font name, or, could use thegoogle_font()function (for specifying a webfont hosted on the Google Fonts service).There is also the new ability to specify a Google Font through
google_font()incell_text()'sfontargument.Here is some testable code:
Fixes: #595
Fixes: #585
Fixes: #589
Fixes: #598
Fixes: #404
cc @jthomasmock