Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify options set in format() #93

Merged
merged 4 commits into from Dec 13, 2018
Merged

Modify options set in format() #93

merged 4 commits into from Dec 13, 2018

Conversation

rich-iannone
Copy link
Member

Some options to format() in the migrate_unformatted_to_output() were left with default values (the trim and justify args), and this results in character values with some padding based on the longest values. While great for console printing, it results in inconsistent formatting in tables.

Here is an example before and after the change with the following code:

dplyr::tibble(idx = 1:10, values = 501:510) %>%
  gt() %>%
  cols_merge(
    col_1 = vars(values),
    col_2 = vars(idx),
    pattern = "{1} ({2})"
  )

before
before

after
after

@rich-iannone rich-iannone merged commit f37b432 into master Dec 13, 2018
@rich-iannone rich-iannone deleted the format-options branch December 14, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant