Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fixes and cleanups for R 3.4.0 #69

Merged
merged 2 commits into from
May 9, 2017
Merged

Build fixes and cleanups for R 3.4.0 #69

merged 2 commits into from
May 9, 2017

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Apr 11, 2017 •
edited
Loading

Fixes errors and warnings on several compilers and platforms:

  • Remove the fixup.h hack, instead use #define STRICT_R_HEADERS
  • Removes redundant #include statements that were causing naming conflicts.
  • Compile with C++11 on supported platforms: fixes several warnings
  • Build legacy libuv code on OSX with -Wno-deprecated-declarations
  • Small linking tweaks for OpenBSD and Solaris
  • Ensure every file ends with EOL (fixes compiler warnings on some platforms)

This has been checked on:

  • Mac OSX 10.9 (Mavericks)
  • Mac OSX 10.12 (Sierra)
  • windows R 3.2 (gcc-4.6.3)
  • windows R 3.3 (gcc-4.9.3)
  • windows r-devel (gcc-4.9.3)
  • Linux r-devel (gcc-6.3.0)
  • FreeBSD 11 (FreeBSD clang version 3.8.0 with export MAKE=gmake)
  • Solaris 10 x86 (use export MAKE=gmake)
  • CentOS 6 (gcc 4.4.7)

Edit: rebased into a single commit.

@jeroen jeroen mentioned this pull request Apr 11, 2017
Closed
@jeroen jeroen mentioned this pull request May 8, 2017
Closed
@jcheng5 jcheng5 merged commit 7b35973 into rstudio:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeroen @jcheng5