Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addLegend should support data argument #491

Closed
jcheng5 opened this issue Feb 9, 2018 · 3 comments
Closed

addLegend should support data argument #491

jcheng5 opened this issue Feb 9, 2018 · 3 comments

Comments

@jcheng5
Copy link
Member

jcheng5 commented Feb 9, 2018

All the other addXXX functions support an explicit data argument, while addLegend assumes that your leaflet object has it. There's no reason for this, just an oversight that should be trivial to fix.
@jcheng5
Copy link
Member Author

jcheng5 commented Feb 9, 2018

See #485

@schloerke schloerke mentioned this issue Feb 12, 2018
Merged
29 tasks
@schloerke
Copy link
Contributor

Adding also to

  • addTiles
  • addRasterImage
  • addWMSTiles
  • addGeoJSON
  • addLayersControl

@schloerke
Copy link
Contributor

fixed in schloerke#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schloerke @jcheng5