v2.0.0

[schloerke]

Resolves #476 (which merges #453, #458, #462, #405, #396, #393).

Remaining PR's to possibly include:

• • Horizontal legend #342 - horizontal legend
  • lots of js changes
  • code review
  • test against all legend types
  • CLA Signed
  • Needs more work. Will wait for next release

• plotly crosstalk experiments #346 - crosstalk for plotly
  • Wait until next release
• addPolygons() now responds to crosstalk events #391 - crosstalk for addPolygons()
  • Wait until next release. Would like to address this functionality properly

• add parameter right to colorBin and colorQuantile function #388 - add parameter right to color cutting
  • CLA Signed
• add info about map center input event to doc #450 - map center info to doc
  • CLA Signed. Only minor documentation. Merged

• addLegend group not working when group is in addLayersControl baseGroups #477 - add legend group not working when group is in addLayersControl baseGroups
  • scope this out

• Remove deprecated br clear #497 - Removed deprecated br clear
  • CLA Signed

Remaining Issues to address:

• us-states.geojson #498 documenting where .json files are located

Tasks left before merging

• update pkg version
  • 1.2.0
  • 2.0.0
    • with the upgrade to 1.3.1, there will most likely be breaks in the js code that people submit. We should make it a 'major' version update.
• Should we update to leaflet.js 1.3.1 ?
  • no. release to public. then upgrade to 1.3.1 (or latest) in next release
  • Yes! leaflet.extras and leaflet.esri need updating. Since we are doing work for both packages, then we should update leaflet version as well.
• Packages ready for rstudio/leaflet 2.0.0
  • leaflet.extras
    • needs leaflet 1.3.1 updates
  • leaflet.esri
    • needs leaflet 1.3.1 updates
  • mapview
  • mapedit
  • sf
• Internal lints
  • with the update of leaflet version, maybe this could be included in the release
• issue addLegend should support data argument #491 - addLegend should support data arg
• leaflet.extras has no zIndex = NULL
• update NEWS with information
  • ... ongoing process
• raster auto method, and color
• add auto method for raster data
• add raster examples
  • numeric
  • character
  • factor
  • weird
• Fix known broken examples (added below)
• run revdepcheck::revdep_check() on final version

Known broken examples:

• FIXED BELOW - From update markercluster->v0.1.1, leaflet-measure->2.1.7, leaflet-omnivore->0.3.4 #458 (which might be related to an updated leaflet-omnivore)

topoData <- readLines("https://d3js.org/us-10m.v1.json") %>% paste(collapse = "\n")
leaflet() %>% setView(lng = -98.583, lat = 39.833, zoom = 3) %>%
  addTiles() %>%
  addTopoJSON(topoData, weight = 1, color = "#444444", fill = FALSE)
# map shows up with no topo viz

[schloerke]

Known broken example:

topoData <- readLines("https://d3js.org/us-10m.v1.json") %>% paste(collapse = "\n")

leaflet() %>% 
  setView(lng = -98.583, lat = 39.833, zoom = 3) %>%
  addTiles() %>%
  addTopoJSON(topoData, weight = 1, color = "#444444", fill = FALSE)

is fixed by changing the data source:

topoData <- readLines("http://bl.ocks.org/mbostock/raw/4090846/us.json") %>% paste(collapse = "\n")

leaflet() %>% 
  setView(lng = -98.583, lat = 39.833, zoom = 3) %>%
  addTiles() %>%
  addTopoJSON(topoData, weight = 1, color = "#444444", fill = FALSE)

I believe Bostock is projecting the data. This raw data from an old block is not geo projected. The raw data is leaflet ready, where as the original data is ready for D3.

[timelyportfolio]

@schloerke thanks for incredibly hard work on this. I will start testing with mapedit.

[jrisi256]

@jcheng5 Hi! I submitted issue #496 (related to #152, #163, #170, and #303), and I didn't quite understand your response to @timelyportfolio by saying "The restyle operation seems like something you should be able to do to anything, not just GeoJSON?" Could you explain further if there are any plans to implement setStyle or restyle? Or if not, could you point out a way/gesture towards how to implement it using some Javascript? Thanks for your time and for helping make such a great package.