RC v2.0.3 #650
Merged
RC v2.0.3 #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: update leaflet.providers import update NEWS with breaking changes activebindings work! use active bindings instead of onLoaded objs remove onLoad update remote in DESC create html_dependency here, restore https handling revert fixup url protocol change add options for leaflet providers updated NEWS remove old providers files finish leaflet.providers integration use dev version of leaflet.providers in DESCRIPTION use html_dependency from leaflet.providers in leafletProviderDependencies delete old .rda data files include version number use onLoad to load data from leaflet.providers
cpsievert
reviewed
Nov 8, 2019
cpsievert
approved these changes
Nov 8, 2019
|
Should this be merged now? |
|
yes. And tag the merge. And set up dev versions.
I can do it it in the morning if you’d like.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make release as
scalesv1.1.0 package will cause failures.system("npm run build")devtools::document()devtools::install()source("scripts/docs_update.R")shiny::runGitHub("rstudio/shiny-examples", subdir = "063-superzip-example")shiny::runGitHub("rstudio/shiny-examples", subdir = "086-bus-dashboard")source("scripts/viztest.R")devtools::release(check=TRUE), (don't actually release in the last step)source("scripts/rhub.R")source("scripts/revdepcheck.R")