Replace {viridis} dependency by {viridisLite}
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
|
I think it would be worth considering, since viridis adds 11 dependencies. With this PR, leaflet would only import 52 packages (compared to 63 currently) |
cpsievert
approved these changes
Feb 16, 2024
schloerke
changed the title
{viridis} dependency by {viridisLite}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Since all the functions used by leaflet from viridis are reexported from viridisLite.
This reduces the total number of leaflet dependencies from 64 to 49.
PR task list:
tests/testthat/R/zzz_viztest.Rdevtools::document()