tests: Skip i18n message translation tests when LC_ALL="C" or "C.UTF-8"
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the R language" This reverts commit 95c16f6.
gadenbuie
changed the title
LC_ALL="C" or "C.UTF-8"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply skips checking that learnr can control the language used for R's messages in known scenarios where the
LANGUAGEenvironment variable is ignored. Currently this is true forLC_ALL="C"and with newer versions of glibc also forLC_ALL="C.UTF-8".In an earlier iteration, I tried directly testing that if we are able to change the language of R message – by trying and succeeding or failing – but this create many more problems than it solved.
Fixes #800
Note that in the future we could maybe use
Sys.setLanguage(), but this was added in R 4.2.0.