Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should addins be removed? #525

Closed
hadley opened this issue Oct 1, 2021 · 4 comments · Fixed by #563
Closed

Should addins be removed? #525

hadley opened this issue Oct 1, 2021 · 4 comments · Fixed by #563
Labels
upkeep maintenance, infrastructure, and similar

Comments

@hadley
Copy link
Member

hadley commented Oct 1, 2021

I didn't notice them earlier so they only work with the old API.

@juliasilge
Copy link
Member

Could this function be deprecated using lifecycle? Would that take care of it?

@hadley
Copy link
Member Author

hadley commented Oct 1, 2021

I was thinking about removing all the files in https://github.com/rstudio/pins/tree/master/inst/rstudio, but it probably should go through a deprecation cycle first if you think people use it.

@juliasilge
Copy link
Member

Honestly I don't have much of a sense of how often these are used (my guess would be not much) so it's a matter of how conservative do you want to be.

@hadley hadley added the upkeep maintenance, infrastructure, and similar label Nov 16, 2021
hadley added a commit that referenced this issue Nov 16, 2021
@hadley hadley mentioned this issue Nov 16, 2021
hadley added a commit that referenced this issue Dec 7, 2021
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants