Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the dots from pin_write() through to s3_upload_file() #648

Merged
merged 5 commits into from Sep 8, 2022

Conversation

juliasilge
Copy link
Member

Closes #628

library(pins)
b <- board_s3(
  "pins-test-hadley", 
  region = "us-east-2",
  access_key = Sys.getenv("PINS_AWS_ACCESS_KEY"),
  secret_access_key = Sys.getenv("PINS_AWS_SECRET_ACCESS_KEY")
)
b %>% pin_write(mtcars, Tagging = "key1=value1&key2=value2")
#> Using `name = 'mtcars'`
#> Guessing `type = 'rds'`
#> Creating new version '20220831T215459Z-66143'
#> Writing to pin 'mtcars'

Created on 2022-08-31 with reprex v2.0.2

@juliasilge
Copy link
Member Author

Also closes #625

@@ -209,14 +215,15 @@ pin_fetch.pins_board_s3 <- function(board, name, version = NULL, ...) {

#' @export
pin_store.pins_board_s3 <- function(board, name, paths, metadata,
versioned = NULL, ...) {
versioned = NULL, x = NULL, ...) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function signature here needed to be made the same as other pin_store methods.

@juliasilge juliasilge requested a review from machow August 31, 2022 23:33
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior LGTM! I didn't try it locally (but am happy to if useful!)

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of S3 tags with pins?
2 participants