Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to board_connect() and other rebranding changes #689

Merged
merged 12 commits into from
Dec 16, 2022
Merged

Change to board_connect() and other rebranding changes #689

merged 12 commits into from
Dec 16, 2022

Conversation

juliasilge
Copy link
Member

Addresses #678

@juliasilge
Initial go, which does not work
10cd0b2
@juliasilge
Merge from main
4a5ebb8 
Merge commit '116b11762b7305407643ae05c82c70667d921965'

#Conflicts:
#	man/board_connect.Rd
@juliasilge
Update many things to Posit Connect
484e2cf
@juliasilge
Copy link
Member Author

This PR does not change:

  • args or functions that are related to the rsconnect R package
  • anything related to the legacy Connect board
  • internal functions that start with rsc like rsc_bundle() or rsc_server()

We can come back to these for further changes later if/when we want.

@juliasilge
Merge from main
b105a0a 
Merge commit '0863d1d39597bd85439f21db0e8ddfaff5591c04'

#Conflicts:
#	R/board_rsconnect.R
#	tests/testthat/_snaps/board_rsconnect.md
#	tests/testthat/_snaps/board_rsconnect_bundle.md
@juliasilge
One more snapshot
a7c6670
@juliasilge
Update snapshot
f102fb5
@juliasilge
Merged origin/main into board-connect
08549af
hadley
hadley approved these changes Dec 16, 2022
View reviewed changes
R/board_connect.R Outdated Show resolved Hide resolved
R/board_connect.R Outdated Show resolved Hide resolved
R/board_connect.R Show resolved Hide resolved
R/board_connect.R Show resolved Hide resolved
@juliasilge juliasilge merged commit cf70d5c into main Dec 16, 2022
@juliasilge juliasilge deleted the board-connect branch December 16, 2022 21:05
@juliasilge juliasilge mentioned this pull request Dec 16, 2022
Closed
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliasilge @hadley