-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vignette for board_url()
#692
Conversation
This looks good so far! I would probably do "Publishing" before "Consuming". |
My first thought was there would be more consumers than publishers, but I agree with you; it would make the programming a whole lot more convoluted. |
@juliasilge - non-urgent question for you: I'm failing the R-CMD-check-hard workflow because webfakes is not a hard dependency. I don't know if the right move is to make it a hard dependency, or instead to add it to the workflow's Thanks! |
You left the answer in the other vignette 😅 |
I think I've got this to a "discussable" point; the sections on publishing and consuming are ready for review. There's an additional section on platforms. I wanted to create examples for Quarto and pkgdown, if for no other reason than to demonstrate clearly to myself that it works. A couple points here:
I also created a section for S3, but I don't have an S3 account. From what I read, it should just work™️ to publish your bucket as a website. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! 🙌 I made a few minor suggestions in the narrative.
I see that we're waiting on something from the Quarto folks to get that squared away. 👍
I see what you mean about those nice example repos you created. Hmmm... Let's keep them there for now, unless we decide there is something better suited for them.
incorporate suggestion Co-authored-by: Julia Silge <julia.silge@gmail.com>
incorporate suggestion Co-authored-by: Julia Silge <julia.silge@gmail.com>
incorporate suggestion 😅 Co-authored-by: Julia Silge <julia.silge@gmail.com>
Hi @juliasilge - thanks for your feedback and patience, we're getting there! I agree that we should let the Quarto folks sort things out, and leave the demo repos where they are until a better solution presents itself. Hopefully be back soon! |
@ijlyttle I think we want to move forward with a pins release fairly expediently, so my plan here is to remove the Quarto section of this vignette and open an issue to add that back in later, when the change is made in Quarto. I'll take a stab at finishing up this vignette! |
Sounds good - hopefully everything gets worked out soon! Please let me know if I can help. I have removed the "draft" label, in case that clears a road-block. |
@ijlyttle Would you mind looking over my edits to see if any changes I made don't make sense? Give it one more look before I merge? |
Hi @juliasilge, it looks great - much improved, in fact! Thanks! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
fix #685
@juliasilge - just to let you know I'm working on this, and to give you an early opportunity to point me back to the right path, if need be.