Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds svg plot option #398

Closed
wants to merge 6 commits into from
Closed

Conversation

pachadotdev
Copy link
Contributor

@pachadotdev pachadotdev commented Mar 14, 2019

works smooth!

@codecov-io
Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.18%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   89.53%   89.34%   -0.19%     
==========================================
  Files          28       28              
  Lines        1414     1417       +3     
==========================================
  Hits         1266     1266              
- Misses        148      151       +3
Impacted Files Coverage Δ
R/images.R 95% <0%> (-5%) ⬇️
R/content-types.R 100% <100%> (ø) ⬆️
R/parse-block.R 95.83% <33.33%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e361005...f3a4ac7. Read the comment docs.

@pachadotdev pachadotdev changed the title halfway svg render, still downloads instead of showing adds svg plot option Mar 14, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2019

CLA assistant check
All committers have signed the CLA.

@pachadotdev
Copy link
Contributor Author

pachadotdev commented Feb 9, 2020

Hi @trestletech. I've been using this modification for ~1 year and it works ok, a client wanted an api to show plots, and I did it with ggplot2 + plumber

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Feb 10, 2020
@pachadotdev pachadotdev mentioned this pull request Apr 7, 2020
@schloerke
Copy link
Collaborator

schloerke commented Apr 7, 2020

This makes sense.

How far should this go? All major graphics devices?

Current:
jpeg, png, (svg)

Possible formats baked into R:
bmp, tiff, pdf, (any others?)

I don't want to import Cairo.

Don't know if we should namespace the image type. Ex:

#' @image jpeg
#' @image tiff
#' @jpeg // allowed as a shorthand version of #' @image jpeg
#' @tiff // not possible

@pachadotdev
Copy link
Contributor Author

pachadotdev commented Apr 7, 2020

I need to think more, I see more value in the CSV PR, but I'll dig into this soon

@schloerke
Copy link
Collaborator

schloerke commented Apr 7, 2020

No rush. Am tied up with shiny for the month. Plan to dive deep on plumber in March.

schloerke added a commit that referenced this pull request Jun 18, 2020
Co-authored-by: pachamaltese <mvargas@dcc.uchile.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants