Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check before guessing content-type #583

Closed
wants to merge 4 commits into from

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jul 3, 2020

In reference to : https://community.rstudio.com/t/uploading-tsv-files-to-plumber-api/71705/3

PR task list:

  • [NA] Update NEWS
  • Add tests
  • Update documentation with devtools::document()

R/parse-body.R Outdated Show resolved Hide resolved
@meztez
Copy link
Collaborator Author

meztez commented Jul 3, 2020

Do you know of a way to prevent git from messing up a binary file that happens to be just text? It seems to strip the last two bytes at the end of the files.

@schloerke
Copy link
Collaborator

From https://stackoverflow.com/a/39461324/591574... maybe add a *.bin binary line to ./gitattributes ?

@meztez
Copy link
Collaborator Author

meztez commented Jul 3, 2020

Thanks. I'll go read a book for a bit. Should have duckducked that. Time for a break.

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Jul 3, 2020
@schloerke schloerke added the Fixed in PR A PR has implemented a fix for this Issue label Jul 3, 2020
@meztez
Copy link
Collaborator Author

meztez commented Jul 4, 2020

Thanks @schloerke

@meztez meztez closed this Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in PR A PR has implemented a fix for this Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants