Restructure serializers. Add serializer_headers() and as_attachment()
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Build each serializer on top of one another to avoid copy/pasta * Add serializer_headers(headers) * Have all text-like content return `charset=UTF-8` * Use an `.onLoad()` method for adding the serializers. (Allows for globals to not be directly altered while the package is loading.) * Remove all serializer files and merge into serializer.R
…tachment(x, filename)`.
schloerke
changed the title
serializer_headersserializer_headers(). Add as_attachment()
schloerke
commented
Jul 6, 2020
cpsievert
reviewed
Jul 9, 2020
cpsievert
reviewed
Jul 9, 2020
cpsievert
reviewed
Jul 9, 2020
cpsievert
reviewed
Jul 9, 2020
cpsievert
requested changes
Jul 9, 2020
blairj09
added a commit
to blairj09/plumber
that referenced
this pull request
Jul 13, 2020
…tudio#585 for serializer_content_type
schloerke
commented
Jul 15, 2020
blairj09
added a commit
to blairj09/plumber
that referenced
this pull request
Jul 16, 2020
…hange introduced in rstudio#585
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
* Replace `jsonlite::fromJSON()` with `jsonlite::parseJSON(simplifyVector = TRUE)` * Add `serializer_print()`, `serializer_format()`, and `serializer_cat()` * Fixed braces in readme
…udio/plumber into content_type_and_disposition
schloerke
changed the title
serializer_headers(). Add as_attachment()serializer_headers() and as_attachment()
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes: #455
Fixes: #482
charset=UTF-8.onLoad()method for adding the serializers. (Allows for globals to not be directly altered while the package is loading.)forceargument to allow serializers to be overwrittenPR task list:
devtools::document()@ycphsas author to NEWS