New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `plumb_api()` and `available_apis()` #631

Merged

schloerke merged 21 commits into master from available_plumbers

Aug 6, 2020

Collaborator

schloerke commented Aug 5, 2020 •

edited

Loading

PR task list:

Update NEWS
Add tests
Update documentation with devtools::document()
Separate documentation for plumber() and plumb()
Update Docker file to accept file location
Remove TODO on inferring the content type in include_file()

schloerke added 8 commits

August 4, 2020 15:14


          Move all examples from ./inst/examples to ./inst/plumber for cros…

a463097

…s package consistency


          Rename plumb_pkg() to plumb_api(). Move all docker pointers from …

959fe8a

…`./examples` to `./plumber`


          Add plumb_api() and available_apis()

a1df57f


          Add test to test that all example apis work with plumb()

0b35a19


          moar docs! add news item

55b0b9f


          When plumbing a file, set the working directory to the file's dir.

007f7ad

This is on par to running a plumber api as the directory is set there as well.


          Add breaking change to the news item when plumbing a file and it's wo…

5577a90

…rking directory


          Infer the content type from the file extension in include_file()

0c8b929

schloerke marked this pull request as ready for review

August 5, 2020 15:44

schloerke requested a review from cpsievert

August 5, 2020 15:44

cpsievert reviewed

View reviewed changes

NEWS.md Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

R/includes.R Outdated Show resolved Hide resolved


          fix tests

532922b

cpsievert reviewed

View reviewed changes

R/plumb.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

R/plumb.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

R/plumb.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

R/plumb.R Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

R/plumb.R Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

NEWS.md Outdated Show resolved Hide resolved

cpsievert reviewed

View reviewed changes

tests/testthat/test-openapi.R Outdated Show resolved Hide resolved

cpsievert self-requested a review

August 5, 2020 19:01

cpsievert approved these changes

View reviewed changes

Contributor

cpsievert left a comment

LGTM pending suggestions

schloerke and others added 8 commits

August 5, 2020 17:07


          When plumbing a file, set the working directory to the file's directo…

310f6f8

…ry. Same for running a plumbed file


          When sourcing the entrypoint file, have the environment point to a gl…

b844d8c

…obal environment


          Fix tests

bbb5abe


          Apply suggestions from code review

d5d5830

Co-authored-by: Carson Sievert <cpsievert1@gmail.com>


          If no package is provided, return all available apis. If no name is p…

e53cfcf

…rovided, return available package apis


          Document that the content_type can be NULL to disable the header

7f16c07


          Use split() rather than duplicate subsetting

e00cd06


          Use available_apis() and plumb_api() when validating plumber obje…

86d9a63

…cts.

schloerke added 4 commits

August 5, 2020 17:50


          Add a helper method to make sure all apis can be tested consistently

c2a26b5


          Add future to make testing more complete

d2c6fec


          allow test on linux as well

9bdcfda


          merge master

2ca0b93

schloerke merged commit 58e84ac into master

schloerke deleted the available_plumbers branch

August 6, 2020 17:21

schloerke added a commit that referenced this pull request


          Merge branch 'master' into validate_openapi

d2d1d5f

* master:
  Add `plumb_api()` and `available_apis()` (#631)
  Allow serializers to return hooks and a serializer function. Port all image serializers to use new functionality (#630)

meztez mentioned this pull request

Version 1.0 breaks relative path #679

Closed

schloerke mentioned this pull request

Need function to run pkg plumber API's #440

Closed

schloerke mentioned this pull request

runExample() improvements rstudio/shiny#3907

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment