Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plumb_api() and available_apis() #631

Merged
merged 21 commits into from Aug 6, 2020
Merged

Add plumb_api() and available_apis() #631

merged 21 commits into from Aug 6, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 5, 2020

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()
  • Separate documentation for plumber() and plumb()
  • Update Docker file to accept file location
  • Remove TODO on inferring the content type in include_file()

@schloerke schloerke marked this pull request as ready for review Aug 5, 2020
@schloerke schloerke requested a review from cpsievert Aug 5, 2020
NEWS.md Outdated Show resolved Hide resolved
R/includes.R Outdated Show resolved Hide resolved
R/plumb.R Outdated Show resolved Hide resolved
R/plumb.R Outdated Show resolved Hide resolved
R/plumb.R Outdated Show resolved Hide resolved
R/plumb.R Outdated Show resolved Hide resolved
R/plumb.R Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
tests/testthat/test-openapi.R Outdated Show resolved Hide resolved
@cpsievert cpsievert self-requested a review Aug 5, 2020
Copy link
Contributor

@cpsievert cpsievert left a comment

LGTM pending suggestions

@schloerke schloerke merged commit 58e84ac into master Aug 6, 2020
14 of 16 checks passed
@schloerke schloerke deleted the available_plumbers branch Aug 6, 2020
schloerke added a commit that referenced this pull request Aug 7, 2020
* master:
  Add `plumb_api()` and `available_apis()` (#631)
  Allow serializers to return hooks and a serializer function. Port all image serializers to use new functionality (#630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants