Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make R6 apis consistent #653

Merged
merged 22 commits into from
Aug 19, 2020
Merged

Make R6 apis consistent #653

merged 22 commits into from
Aug 19, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 18, 2020 •
edited
Loading

See commits for api conversions.

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 18, 2020
cpsievert
cpsievert reviewed Aug 18, 2020
View reviewed changes
R/plumber.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 18, 2020
View reviewed changes
NEWS.md Show resolved Hide resolved
@schloerke
Copy link
Collaborator Author

schloerke commented Aug 19, 2020 •
edited
Loading

Minimal News items to add:

  • plumberstatic is now PlumberStatic
  • plumber is now Plumber. plumber throws a deprecated message
  • is_plumber() - new method

cpsievert
cpsievert reviewed Aug 19, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@schloerke schloerke merged commit fdcd33e into master Aug 19, 2020
@schloerke schloerke deleted the api_consistencies branch August 19, 2020 22:18
@schloerke schloerke mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schloerke @cpsievert