Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return invisible(pr) for pr_*() #740

merged 3 commits into from Dec 30, 2020

Do not return invisible(pr) for pr_*() #740

merged 3 commits into from Dec 30, 2020


Copy link

@schloerke schloerke commented Dec 30, 2020

I had done some magrittr style work and did not immediately run the router. When the commands finished, the router did not display... that was confusing. Now it will display.

Without PR:

> pr() %>% pr_get("/route", identity)

With PR:

> pr() %>% pr_get("/route", identity)
# Plumber router with 1 endpoint, 4 filters, and 0 sub-routers.
# Call run() on this object to start the API.
└──/route (GET)

PR task list:

  • Update NEWS
  • [na] Add tests
  • Update documentation with devtools::document()

@schloerke schloerke marked this pull request as ready for review December 30, 2020 14:16
@schloerke schloerke changed the title If a pr command is executed, let the return value be printed. No need to hide it Do not return invisible(pr) for pr_*() Dec 30, 2020
@schloerke schloerke merged commit 9d29510 into master Dec 30, 2020
1 check passed
@schloerke schloerke deleted the pr_return branch December 30, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant