Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A complete tidyselect integration for the columns argument in validation functions #493

Merged
merged 42 commits into from
Oct 28, 2023
Merged

A complete tidyselect integration for the columns argument in validation functions #493

merged 42 commits into from
Oct 28, 2023

Commits on Oct 17, 2023

  1. streamlining internal tidyselect first draft

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b09ded9 View commit details
    Browse the repository at this point in the history

  2. [temp] make error msg regex test generally for column-related error

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5cedd20 View commit details
    Browse the repository at this point in the history

  3. keep original deparse handling of vars

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2d939aa View commit details
    Browse the repository at this point in the history

  4. be intentional about passing character vector of columns

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3f7cce4 View commit details
    Browse the repository at this point in the history

  5. remove expr constraint to bring the environment along for ordinary ev… 

    …aluation in all_of
    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1f04ebc View commit details
    Browse the repository at this point in the history

  6. work with vars() as expr not quosure since we don't care about the env

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    85217be View commit details
    Browse the repository at this point in the history

  7. don't use all_of() for ordinarily evaluated column argument

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9fcbaed View commit details
    Browse the repository at this point in the history

  8. more explicit code for resolving tbl

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e72e49b View commit details
    Browse the repository at this point in the history

  9. exception for when tbl is empty like in specially()

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ac65f40 View commit details
    Browse the repository at this point in the history

  10. use tidyselect in rows_distinct

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d386432 View commit details
    Browse the repository at this point in the history

  11. tidyselect tests first draft

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1382a08 View commit details
    Browse the repository at this point in the history

  12. namespace tidyselect fns in test

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    099ba5f View commit details
    Browse the repository at this point in the history

  13. revert all_of for create_validation_step, which uses ordinary evaluation

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7e55558 View commit details
    Browse the repository at this point in the history

  14. use all_of

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    14f9878 View commit details
    Browse the repository at this point in the history

  15. implement behavior of NULL with everything()

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4cc1c84 View commit details
    Browse the repository at this point in the history

  16. relax regexp for column not found error

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    91d3102 View commit details
    Browse the repository at this point in the history

  17. tests expect column info from row_distinct() validation step

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d7c1eff View commit details
    Browse the repository at this point in the history

  18. add test for tidyselect where support

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7b3ee39 View commit details
    Browse the repository at this point in the history

  19. clean up resolve_columns

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9bc5524 View commit details
    Browse the repository at this point in the history

  20. use quo_is_null

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    982d4c5 View commit details
    Browse the repository at this point in the history

  21. use quo_is_call

    @yjunechoe
    yjunechoe committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    719cf6f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. simplify defaulting to everything() when column is NULL for rows_dist… 

    …inct()
    @yjunechoe
    yjunechoe committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    5bbe101 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. [chore] probe_columns helpers marked for always receiving chr input

    @yjunechoe
    yjunechoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    646ec8e View commit details
    Browse the repository at this point in the history

  2. [chore] some more all_of coverage

    @yjunechoe
    yjunechoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    1978e8d View commit details
    Browse the repository at this point in the history

  3. linter

    @yjunechoe
    yjunechoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    65ae1ad View commit details
    Browse the repository at this point in the history

  4. tidyselect errors only in non-validation-building contexts

    @yjunechoe
    yjunechoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a50643d View commit details
    Browse the repository at this point in the history

  5. missing columns for selection marked as NA

    @yjunechoe
    yjunechoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    35ae592 View commit details
    Browse the repository at this point in the history

  6. Resolve to NA for when NULL passed to columns argument

    @yjunechoe
    yjunechoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    dddfd1e View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. force tbl/agent in resolve_columns to avoid interrupt promise warnings

    @yjunechoe
    yjunechoe committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    af394ab View commit details
    Browse the repository at this point in the history

  2. tests for tidyselect column selection error behaviors

    @yjunechoe
    yjunechoe committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7111ed2 View commit details
    Browse the repository at this point in the history

  3. test status in validation set directly

    @yjunechoe
    yjunechoe committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    726aed6 View commit details
    Browse the repository at this point in the history

  4. [chore] replace .env$ with all_of()

    @yjunechoe
    yjunechoe committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7e492bd View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. tidyselect columns in rows_complete

    @yjunechoe
    yjunechoe committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    bbacbc7 View commit details
    Browse the repository at this point in the history

  2. test 0-column selection behavior for rows_* validation functions

    @yjunechoe
    yjunechoe committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    56fb16f View commit details
    Browse the repository at this point in the history

  3. add june as aut

    @yjunechoe
    yjunechoe committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    4f07e53 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. use all_of

    @yjunechoe
    yjunechoe committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0585392 View commit details
    Browse the repository at this point in the history

  2. clean up tidyselect test file

    @yjunechoe
    yjunechoe committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f07e396 View commit details
    Browse the repository at this point in the history

  3. tests expect column info from row_complete() validation step

    @yjunechoe
    yjunechoe committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    7b8c66c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. tidyselect for col_exists(); resolves rstudio#433

    @yjunechoe
    yjunechoe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    2255b41 View commit details
    Browse the repository at this point in the history

  2. test tidyselect for col_exists()

    @yjunechoe
    yjunechoe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    be5725e View commit details
    Browse the repository at this point in the history

  3. more tests for vars() backwards compatibility

    @yjunechoe
    yjunechoe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    8ec5486 View commit details
    Browse the repository at this point in the history

  4. col_exists() only fails and never errors for missing column selection

    @yjunechoe
    yjunechoe committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    3461c33 View commit details
    Browse the repository at this point in the history