Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging codecov #498

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Debugging codecov #498

merged 4 commits into from
Oct 31, 2023

Conversation

yjunechoe
Copy link
Collaborator

@yjunechoe yjunechoe commented Oct 31, 2023 •
edited

Trying to debug codecov GHA failure by hitting it directly in this PR.

@yjunechoe yjunechoe marked this pull request as draft October 31, 2023 12:53
@yjunechoe yjunechoe mentioned this pull request Oct 31, 2023
Merged
27 tasks
@yjunechoe
Copy link
Collaborator Author

🤦I introduced the fails because test-draft_validation.R skips on windows (which I use) - since I haven't been updating the snaps, the GHA has been running snapshot tests against outdated snaps and failing this whole time (because draft_validation() now writes c() instead of vars()).

@rich-iannone I also edited the codecov workflow file to include a "show testthat output" step, which could be useful for future debugging. Can I merge this in as well?

@yjunechoe yjunechoe marked this pull request as ready for review October 31, 2023 13:59
@rich-iannone
Copy link
Member

Showing the testthat output is great. Thank you for solving this!

rich-iannone
rich-iannone approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rich-iannone
Copy link
Member

(Go ahead and merge this yourself.)

@yjunechoe yjunechoe merged commit a9e269f into rstudio:main Oct 31, 2023
13 checks passed
@yjunechoe yjunechoe deleted the debug-codecov branch October 31, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yjunechoe @rich-iannone