Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use in-header.html? #5

Closed
maelle opened this issue Feb 15, 2021 · 2 comments · Fixed by #20
Closed

use in-header.html? #5

maelle opened this issue Feb 15, 2021 · 2 comments · Fixed by #20

Comments

@maelle
Copy link
Contributor

maelle commented Feb 15, 2021

Since you are using dev pkgdown anyway, do you think that instead of using a template for head.html you could put all your overrides in in-header.html? See https://pkgdown.r-lib.org/dev/news/index.html#pkgdown-development-version-unreleased

I had a look at your head.html and I'm not sure you only add things, though. E.g. you directly write the GA tag which you couldn't do via in-header.html.

@apreshill
Copy link
Contributor

Thank you! I'll look into that. I did the GA tag following tidytemplate, not sure how that differs from injecting the GA tag into the yaml? https://github.com/tidyverse/tidytemplate/blob/b819e3028b4b9342aeac238de147821bbb4c517c/inst/pkgdown/templates/head.html#L79-L87

https://pkgdown.r-lib.org/reference/build_site.html#yaml-config-template

@maelle
Copy link
Contributor Author

maelle commented Feb 15, 2021

I think the problem with GA in YAML is that there is no good way yet to share the ID without asking all users of the template package to put the YAML field in their pkgdown config file. Related to r-lib/pkgdown#1499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants