Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renv_dcf_read_impl relies on iconv, which returns NA on error #908

Closed
rfaelens opened this issue Jan 6, 2022 · 3 comments
Closed

renv_dcf_read_impl relies on iconv, which returns NA on error #908

rfaelens opened this issue Jan 6, 2022 · 3 comments

Comments

@rfaelens
Copy link

rfaelens commented Jan 6, 2022

When installing Mikata-Project/ggthemr@4a31e0d, I receive an error that the DESCRIPTION file is empty.

Instead, there is an encoding error in the DESCRIPTION file (see Mikata-Project/ggthemr#53).

The error message from renv_dcf_read_impl should be more descriptive, e.g. Failed to convert DESCRIPTION (882 bytes) to Encoding X.
@kevinushey
Copy link
Collaborator

Thanks for the bug report -- I'll take a look!

@kevinushey
Copy link
Collaborator

Thanks! Should now be fixed in the development version of renv.

@rfaelens
Copy link
Author

rfaelens commented Jan 7, 2022

Thanks! Love your test case 🔥 🍰

lorenzwalthert added a commit to lorenzwalthert/precommit that referenced this issue Jan 9, 2022
@lorenzwalthert
use dev version to avoid rstudio/renv#908
1b3c862
lorenzwalthert added a commit to lorenzwalthert/precommit that referenced this issue Jan 10, 2022
@lorenzwalthert
use dev version to avoid rstudio/renv#908
f8b2cde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfaelens @kevinushey