Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for _repr_markdown_ IPython methods #1256

Merged
merged 3 commits into from
Aug 9, 2022
Merged

add support for _repr_markdown_ IPython methods #1256

merged 3 commits into from
Aug 9, 2022

Conversation

cscheid
Copy link
Member

@cscheid cscheid commented Aug 8, 2022

This addresses an issue with quarto users who expect the behavior of Python cells to more closely match those of quarto's Jupyter engine.

I'm happy to add supporting tests/documentation, though I could use some help navigating your expectations on that!

(@kevinushey thanks for the help!)

@t-kalinowski
Copy link
Member

Hi @cscheid this looks great. Thank you very much!

As far as tests and docs I think this should be sufficient:

  • A news entry
  • An additional chunk or chunks added to this Rmd, or, if you'd prefer, a stand-alone Rmd similar to the "eng-reticulate-example.Rmd" that gets rendered as part of a test like this.
  • If there is a particular python package you want us to test against please add to the GHA setup here

Thanks again!

Copy link
Collaborator

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants