Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some options in reveal_options are surrounded by two pairs of single quotes #72

Closed
iain-palmer opened this issue Oct 23, 2019 · 4 comments · Fixed by #91
Closed

Some options in reveal_options are surrounded by two pairs of single quotes #72

iain-palmer opened this issue Oct 23, 2019 · 4 comments · Fixed by #91

Comments

@iain-palmer
Copy link

Some settings in reveal_options get surrounded by an extra set of single-quotes. For example, in the Rmd file, these settings:

parallaxBackgroundImage: "https://s3.amazonaws.com/hakim-static/reveal-js/reveal-parallax-1.jpg"
parallaxBackgroundSize: "2100px 900px"

Become (in the html):

parallaxBackgroundImage: ''https://s3.amazonaws.com/hakim-static/reveal-js/reveal-parallax-1.jpg''
parallaxBackgroundSize: ''2100px 900px''

With a pair of single quotes either side. The extra set of single quotes in the html then need to be manually deleted.

@jjallaire
Copy link
Member

jjallaire commented Oct 24, 2019 via email

@iain-palmer
Copy link
Author

Please see these files:
revealjs_issue72_example.zip

  • revealjs_issue72_example.Rmd - example Rmd file
  • revealjs_issue72_example.html - html file output from the above (doesn't display properly in chrome)
  • revealjs_issue72_example_modified.html - html file with lines 6548 & 6550 manually edited (does display properly in chrome)

Hope this helps!
Iain

@jjallaire
Copy link
Member

Okay, thanks, that's very helpful!

Should be fixed here: 633c05f

@iain-palmer
Copy link
Author

Checked, works for me now. Thank you!

cderv added a commit that referenced this issue Jul 26, 2021
* Revert "don't quote reveal options in template". This reverts commit 633c05f fixing #72 
* Only quote specific option that can be character or else like slideNumber https://revealjs.com/slide-numbers/
cderv added a commit that referenced this issue Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants