Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add md_extensions option #75

Merged
merged 2 commits into from Mar 2, 2020
Merged

Add md_extensions option #75

merged 2 commits into from Mar 2, 2020

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Feb 14, 2020

To improve consistency with other formats (e.g., rmarkdown::html_document)

@atusy
Copy link
Contributor Author

atusy commented Feb 14, 2020

Forgotten to mention this PR closes #68

from = rmarkdown_format(ifelse(fig_caption,
"",
"-implicit_figures")),
from = rmarkdown_format(paste0(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this the same way that slidy_presentation does (https://github.com/rstudio/rmarkdown/blob/07b238ceee3aa428acdfbb7351c1cfd9ae48e3f7/R/slidy_presentation.R#L95). Basically chain it together with smart then pass the result (along with fig_caption) to from_rmarkdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Do we check Pandoc's version > 2.0 as slidy_presentation does?
For the smart option, revealjs_presentation does not check it, but slidy_presentation does.
Unfortunately, rmarkdown package does not export smart_extiensions nor pandoc2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do the v2.0 check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently, I noticed that the smart option is meaningless.
Maybe it is a choice for revealjs_presentation to drop the smart option for the better connection with Pandoc.
rstudio/rmarkdown#1774

@jjallaire jjallaire merged commit 8127870 into rstudio:master Mar 2, 2020
cderv added a commit that referenced this pull request Sep 23, 2021
This should have been done this way in #75 when support was added for `md_extensions`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants