Use htmltools functions for htmlwidget notebook annotation #1799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1762
The issue was in the unpreserving html widget code for UFT8 special character encoded on two byte. (see #1762 (comment)).
Using the
htmltools
functions to deal with preserved code extraction seems now the way to do it.I tried to add a test by simplifying the code I used to come up with the solution. Not sure if this is the simplest unit test. Also I added☺️
skip_on_cran()
because the other test had this tooIn addition, I think this could also have been resolved by making sure to use
bytes
Encoding before usingsubstrings
like inrmarkdown/R/util.R
Lines 283 to 288 in 1c859f4
However,
htmltools
functions seemed dedicated to this usage.