Don't add anchors to empty headings #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks ! LGTM |
|
@gadenbuie I bumped the version so that you could easily depend on rmarkdown 2.5.3 |
cderv
added a commit
that referenced
this pull request
Dec 7, 2020
fix which has been done in JS in #1938
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: sorry the PR was submitted accidentally before I could add the description.
This PR fixes #1937 by ensuring that anchors are not added to empty headings.
I also added a CSS rule that hides anchor sections if they end up being a direct child of a list item. This happens on the rare occasion where the HTML is rewritten by another script after anchor sections are added. See rstudio/learnr#446 for such an example.
Finally, I bumped anchor sections to
1.0.1inhtml_dependency_anchor_sections().All of the above were committed individually so you can cherry pick as needed.