Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweaks intermediates #2098

Merged
merged 4 commits into from
Apr 8, 2021
Merged

tweaks intermediates #2098

merged 4 commits into from
Apr 8, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Apr 8, 2021

knitr 1.24+ and rmarkdown 2.0+ only accepts UTF-8 so *.utf8.md is not needed anymore

closes #2086

@cderv
remove utf8.md intermediates that is not needed anymore
e83f809 
knitr 1.24+ and rmarkdown 2.0+ only accepts UTF-8
yihui
yihui approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! Let's see if we would discover any problems when checking the reverse dependencies the next time we make the CRAN release.

@yihui yihui mentioned this pull request Apr 8, 2021
Closed
@cderv
Copy link
Collaborator Author

cderv commented Apr 8, 2021 •
edited
Loading

@yihui I added the simplest for now: an option rmarkdown.knit.ext to customize *.knit.<ext>

This would allow to generate .knit.md~ in blogdown, which should be enough.

Do you think it should be better to customize the all extension:

  • default: *.knit.md
  • customized : *.<ext>
    it does not seem necessary and it is more change in code base (but easy)

When ready to merge I'll add NEWS bullet

yihui
yihui approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current method you provided is enough (it doesn't matter if it is *.knit.md~ or *.md~). No need to do further work. Thanks!

@cderv cderv marked this pull request as ready for review April 8, 2021 16:07
@cderv cderv changed the title remove unnecessary intermediates tweaks intermediates Apr 8, 2021
@cderv cderv merged commit 92b437a into master Apr 8, 2021
@cderv cderv deleted the remove-interm-utf8 branch April 8, 2021 16:14
@cderv cderv mentioned this pull request Apr 8, 2021
Closed
@cderv cderv mentioned this pull request May 28, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop the intermediate files *.knit.md and *.utf8.md
2 participants
@cderv @yihui