Make sure yaml::yaml.load() marks character output as UTF-8 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I just realized that I forgot to consider the character encoding in |
|
Done. |
|
@jmcphers Does this PR look okay to you? (want to merge it soon so it gets into the preview) |
|
Yes, this looks good to me. Thanks @yihui! |
jmcphers
added a commit
that referenced
this pull request
Apr 29, 2015
Make sure yaml::yaml.load() marks character output as UTF-8
yihui
added a commit
to yihui/knitr
that referenced
this pull request
Apr 30, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a function
mark_utf8()to mark all character strings as UTF-8 recursively ifyaml.load()returns a list.