Check for NA in chunk lines (tolerate mismatched encodings); fixes #924 #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue in which Shiny R Markdown deployed to shinyapps.io does not always render properly there. It's caused when files with Latin1 Windows encoding are treated as UTF-8 on shinyapps.io and there are certain Latin characters in the file (in this case it's ñ).
This is just a workaround which allows the app to function even though the encoding is not correct; it does not solve the underlying issue. What's really needed is work in the bundle to persist the file's encoding in its deployment bundle so that it can be used as an argument to
rmarkdown::runon shinyapps.io and Connect, or to translate all code-bearing files in the bundle from native encodings to UTF-8 prior to bundling them.