Add reticulate support for conda #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
reviewed
Mar 6, 2020
R/bundle.R
Outdated
|
|
||
| tryCatch({ | ||
| output <- system2(command = python, args = args, stdout = TRUE, stderr = NULL, wait = TRUE) | ||
| if(require('reticulate') && reticulate::py_config()$anaconda && !compatibilityMode) { |
There was a problem hiding this comment.
Suggested change
| if(require('reticulate') && reticulate::py_config()$anaconda && !compatibilityMode) { | |
| if (requireNamespace('reticulate', quietly = TRUE) && reticulate::py_config()$anaconda && !compatibilityMode) { |
There was a problem hiding this comment.
You might also want to check reticulate::py_available(initialize = FALSE) as otherwise calling reticulate::py_config() will force reticulate to initialize Python.
There was a problem hiding this comment.
I'm using 'reticulate' %in% installed.packages() to avoid including reticulate in the namespace where it doesn't belong.
Co-Authored-By: Kevin Ushey <kevin@rstudio.com>
Co-Authored-By: Kevin Ushey <kevin@rstudio.com>
Co-Authored-By: Kevin Ushey <kevin@rstudio.com>
Co-Authored-By: Kevin Ushey <kevin@rstudio.com>
Co-Authored-By: Kevin Ushey <kevin@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new args to
deployApp(and therefore everydeployfunction that usesdeployAppand passes args) andwriteManifest:forceGeneratePythonEnvironment: write a python environment file even if it existsforceRequirementsTxtEnvironment: write arequirements.txtfile even if we're in a conda environmentUpdated
environment.pyto the latest version from https://github.com/rstudio/rsconnect-python/blob/2b8c5fe249e254e4b0dfdfa21301241375fbe49b/rsconnect/environment.pyReview Notes
environment.pydoesn't need to be reviewed a second timepaste0isn't used because it's not supported under our minimum version of R. (is there a tool we can use to give us these hints?)