Add verbose option to writeManifest() #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
requested changes
May 14, 2021
R/bundle.R
Outdated
| @@ -937,13 +957,15 @@ performPackratSnapshot <- function(bundleDir) { | |||
| } | |||
|
|
|||
| # generate a snapshot | |||
| suppressMessages( | |||
| # suppressMessages( | |||
There was a problem hiding this comment.
Why is this commented out? Do we want to see these messages even if verbose is turned off?
R/bundle.R
Outdated
| @@ -853,6 +869,7 @@ addPackratSnapshot <- function(bundleDir, implicit_dependencies = c()) { | |||
| # rethrow error so we still halt deployment | |||
| stop(e) | |||
| }) | |||
| # if (verbose) logger(" - done performing packrat snapshot") | |||
There was a problem hiding this comment.
Here and elsewhere -- it is not clear why this code is commented out; please either uncomment it or remove it.
Merge branch 'master' into andrie-verbose-manifest # Conflicts: # R/bundle.R
andrie
force-pushed
the
andrie-verbose-manifest
branch
from
0b36ada
to
fff5edd
Compare
jmcphers
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
verbose = FALSEargument to writeManifest(), and pass this through to createAppManifest(), in order to benefit from improved verbose logging in packrat.