Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle host changes #760

Open
hadley opened this issue Mar 13, 2023 · 1 comment
Open

Handle host changes #760

hadley opened this issue Mar 13, 2023 · 1 comment
Labels
deploy ⛹️ feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Mar 13, 2023

After #754 is merged, we'll have the capability to follow redirects and hence determine if a connect server has been moved. It's fine to just redirect only the path has changed, but we should require user confirmation if the hostname has changed. This is probably best accomplished as pre-flight check in deployApp().

If the hostname has changed, need to:

  • Confirm it's ok with the user. (Or error if not interactive)
  • Create a new server with updated name and url.
  • Update the old server with a field indicating that it redirects to a new server.
  • On deployment, detect that the server has been redirected and update deployment record with new details.
@hadley
Copy link
Member Author

hadley commented Mar 13, 2023

Somewhat connected to #49

@hadley hadley added feature a feature request or enhancement deploy ⛹️ labels Mar 20, 2023
@hadley hadley modified the milestone: 1.0.0 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy ⛹️ feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant