don't show size ui for image with no natural sizes

rstudio · Mar 23, 2020 · c6d973e · c6d973e
1 parent 9491bf5
commit c6d973e
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/gwt/src/org/rstudio/studio/client/panmirror/dialogs/PanmirrorEditImageDialog.java b/src/gwt/src/org/rstudio/studio/client/panmirror/dialogs/PanmirrorEditImageDialog.java
@@ -173,7 +173,7 @@ public PanmirrorEditImageDialog(PanmirrorImageProps props,
       // (i.e. not an insert operation) and there aren't width or height attributes 
       // within props.keyvalue (which is an indicator that they use units unsupported
       // by our sizing UI (e.g. ch, em, etc.)
-      if (editAttributes && dims_ != null && !hasSizeKeyvalue(props.keyvalue))
+      if (editAttributes && dims_ != null && hasNaturalSizes(dims) && !hasSizeKeyvalue(props.keyvalue))
       {
          imageTab.add(sizePanel);
       }
@@ -404,6 +404,11 @@ private static boolean hasSizeKeyvalue(String[][] keyvalue)
       return false;
    }
 
+   private static boolean hasNaturalSizes(PanmirrorImageDimensions dims)
+   {
+      return dims.naturalWidth != null && dims.naturalHeight != null;
+   }
+
    // resources
    private static PanmirrorDialogsResources RES = PanmirrorDialogsResources.INSTANCE;