use shared style for character count

rstudio · Aug 12, 2019 · cef7a94 · cef7a94
1 parent 8a98d4b
commit cef7a94
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/src/gwt/src/org/rstudio/studio/client/workbench/views/vcs/git/dialog/GitReviewPanel.css b/src/gwt/src/org/rstudio/studio/client/workbench/views/vcs/git/dialog/GitReviewPanel.css
@@ -152,13 +152,4 @@
 
 .ignoreWhitespace label {
 	margin-left: 4px;
-}
-
-.charCountPanel {
-   position: absolute;
-   left: -10000px;
-   top: auto;
-   width: 1px;
-   height: 1px;
-   overflow: hidden;
 }
diff --git a/src/gwt/src/org/rstudio/studio/client/workbench/views/vcs/git/dialog/GitReviewPanel.java b/src/gwt/src/org/rstudio/studio/client/workbench/views/vcs/git/dialog/GitReviewPanel.java
@@ -117,8 +117,6 @@ interface Styles extends SharedStyles
 
       String splitPanelCommit();
       String ignoreWhitespace();
-
-      String charCountPanel();
    }
 
    @SuppressWarnings("unused")

diff --git a/src/gwt/src/org/rstudio/studio/client/workbench/views/vcs/git/dialog/GitReviewPanel.ui.xml b/src/gwt/src/org/rstudio/studio/client/workbench/views/vcs/git/dialog/GitReviewPanel.ui.xml
@@ -5,6 +5,7 @@
              xmlns:rs_widget='urn:import:org.rstudio.core.client.widget'>
 
    <ui:with field="res" type="org.rstudio.studio.client.workbench.views.vcs.git.dialog.GitReviewPanel.Resources"/>
+   <ui:with field="themeRes" type="org.rstudio.core.client.theme.res.ThemeResources"/>
 
    <g:SplitLayoutPanel ui:field="splitPanel_" styleName="{res.styles.splitPanel}">
       <g:north size="230">
@@ -26,7 +27,7 @@
                              <g:cell horizontalAlignment="ALIGN_RIGHT">
                                <g:HTMLPanel>
                                   <g:Label ui:field="lblCharCount_"/>
-                                  <g:HTMLPanel ui:field="panelCharCount_" styleName="{res.styles.charCountPanel}">
+                                  <g:HTMLPanel ui:field="panelCharCount_" styleName="{themeRes.themeStyles.visuallyHidden}">
                                      <g:Label ui:field="lblReaderCharCount_"/>
                                   </g:HTMLPanel>
                                </g:HTMLPanel>