Source markdown editor uses R code autocompletion and syntax highlighting for third-party knitr engines

[andresrcs]

System details

RStudio Edition : Server
RStudio Version : 2022.12.1+365
OS Version      : Ubuntu 22.04.1 LTS
R Version       : 4.2.2

Steps to reproduce the problem

• Create an Rmd document and add a code chunk with a third-party knitr engine

```{r}
#| echo: false

library(DBI)
library(prqlr)
con <- dbConnect(RSQLite::SQLite(), ":memory:")
dbWriteTable(con, "mtcars", mtcars)
```

```{prql}
#| connection: con

from mtcars
filter cyl > 6
select [cyl, mpg]
derive [mpg_int = round 0 mpg]
take 3
```

Describe the problem in detail

The code chunk has R code autocompletion and syntax highlighting (in source mode) even if I'm using a different language, PRQL.

Describe the behavior you expected

Ideally, I would like the code autocompletion and syntax highlighting to be extensible by third-party packages but I think at least it shouldn't have the same behavior as with R code.

• I have read the guide for submitting good bug reports.
• I have installed the latest version of RStudio, and confirmed that the issue still persists.
• If I am reporting an RStudio crash, I have included a diagnostics report.
• I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

[ronblum]

Thanks @andresrcs! I can also reproduce this in RStudio Desktop 2022.07.2+576, so it's been this way for a while (if not always). Also, from what I can tell, this works correctly in visual mode

[kevinushey]

See:

rstudio/src/gwt/acesupport/acemode/rmarkdown_highlight_rules.js

Lines 157 to 165 in 50250e0

	// Embed sql highlighting rules
	Utils.embedRules(
	this,
	SqlHighlightRules,
	"sql",
	this.$reSqlChunkStartString,
	this.$reChunkEndString,
	["start", "listblock", "allowBlock"]
	);

rstudio/src/gwt/acesupport/acemode/rmarkdown_highlight_rules.js

Line 293 in 50250e0

this.$reSqlChunkStartString = engineRegex("sql");

We could add 'prql' as a language for which we should use SQL-style highlighting. Would you be willing to submit a PR?

[eitsupi]

We could add 'prql' as a language for which we should use SQL-style highlighting.

Thanks for suggestion.
However, the syntax of PRQL is quite different from that of SQL, so a separate definition file must be added.
https://prql-lang.org/book/internals/syntax-highlighting.html

As far as the source code is concerned, do we need Ace format files?
I looked into it and it looks like these can be converted from Textmate format files?
https://github.com/ajaxorg/ace/wiki/Importing-.tmtheme-and-.tmlanguage-Files-into-Ace

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

[eitsupi]

unstale

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

[eitsupi]

unstale