Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prql code chunks use R code autocompletion and syntax highlighting #93

Closed
andresrcs opened this issue Feb 26, 2023 · 6 comments
Closed

Comments

@andresrcs
Copy link

andresrcs commented Feb 26, 2023

I guess prql autocompletion would need to be implemented on the RStudio IDE side but could it be possible to disable autocompletion as if it was R code and maybe use SQL syntax highlighting?

I just noticed this only happens when you have the "Source" markdown editor enabled on the RStudio IDE

@eitsupi
Copy link
Member

eitsupi commented Feb 27, 2023

Could you please open the issue in RStudio IDE repo as I believe that is a function of the IDE?

For example, I believe the following line, which I believe is part of the source code in the visual editor, defines all languages and may not work properly with code blocks that are not part of this definition.
https://github.com/quarto-dev/quarto/blob/973233520f1076b9eba9d2703648bf2a75ea90b7/packages/editor-core/src/languages.ts#L16-L116

For example, would something like the comment code block (knitr 1.37's new feature) not listed there work properly?
https://github.com/yihui/knitr/releases/tag/v1.37

@andresrcs
Copy link
Author

Thanks, I'll give it a try.

I just wanted to be sure this was not something you could enable/disable on your side (I'm clearly not a developer, sorry)

@andresrcs andresrcs closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
@eitsupi
Copy link
Member

eitsupi commented Feb 27, 2023

Don't mind.

I think this feature is important for knitr's IDE integration in general, so I would be happy to link this issue to your open issue on IDE repo if you would like.

@eitsupi
Copy link
Member

eitsupi commented Feb 28, 2023

Thanks creating rstudio/rstudio#12767

@andresrcs
Copy link
Author

They are asking for a PR for enabling prql syntax highlighting, would you be willing to tackle the issue?. As I said before, I'm not a developer so I don't have the required skill set to do it myself.

@eitsupi
Copy link
Member

eitsupi commented Mar 7, 2023

I replied to rstudio/rstudio#12767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants