Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test results trigger error for missing sources #2593

Closed
javierluraschi opened this issue Apr 4, 2018 · 0 comments
Closed

Test results trigger error for missing sources #2593

javierluraschi opened this issue Apr 4, 2018 · 0 comments
Assignees
@javierluraschi
Labels
bug

Comments

@javierluraschi
Copy link
Contributor

Try bigrquery and break a test from DBItest, user consistently gets a file not found error when I click on a test failure.

"I might be assuming that some path exists in the current wd, when it might actually be in another package" which is the case, Hadley's suggestion: Maybe check the file exists before trying to open it?
@javierluraschi javierluraschi self-assigned this Apr 4, 2018
@javierluraschi javierluraschi changed the title Test results not clickable for failures caused in other packages Test results trigger error for missing sources Apr 4, 2018
@javierluraschi javierluraschi mentioned this issue Jun 9, 2018
Merged
javierluraschi added a commit that referenced this issue Jun 11, 2018
@javierluraschi
Merge pull request #2964 from rstudio/bugfix/test-improvement-file-mi…
ac9370b 
…ssing-noerr

Avoid triggering file not found error for test files to fix #2593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javierluraschi javierluraschi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javierluraschi